Don't build ~noreturn
commitf14db589cd0c96b6b79158b8baa5e39ba0ce5287
authorScott Owens <sowens@meta.com>
Thu, 29 Sep 2022 17:13:02 +0000 (29 10:13 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 29 Sep 2022 17:13:02 +0000 (29 10:13 -0700)
tree4fb61d99fa36a35bc4ddcba9430d0c274e6cea54
parent2df7b26b60ce78ab7f89f6680202ca8441c90509
Don't build ~noreturn

Summary: The like-type application rule for __SDT functions was always adding a ~ to the return type of the called function, which was obscuring `noreturn` functions. In fact it never makes sense to add ~ to noreturn, so don't.

Reviewed By: vassilmladenov

Differential Revision: D39928099

fbshipit-source-id: 5fe45ced7abc4c0d6e6858c55c280a870c6b11e4
hphp/hack/src/typing/typing_make_type.ml
hphp/hack/test/sound_dynamic/typing/noreturn.good.php
hphp/hack/test/typecheck/mixed_subtype.php.tgt_pess_exp [deleted file]