| commit | f1231364460465b545a4acd97f4cab3fabd5056b | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Sat, 19 Dec 2020 07:00:58 +0000 (18 23:00 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 19 Dec 2020 07:02:43 +0000 (18 23:02 -0800) | ||
| tree | d6b93815fd2a19471197ab076c3781aa46fc7f71 | treesnapshot (tar.gz zip) |
| parent | 65bd8731986cd709017bbf9727646d20c4a0ad27 | commitdiff |
Drop native Shapes::idx 'optimization'
Summary:
The only purpose of making Shapes::idx a native call was to force it to be inlined via FCallBuiltin so that we could use the offset lookup optimization for these array accesses.
Now that FCallBuiltin is dead, we'll never do this profiling. That means a pure Hack implementation will work as well as the builtin.
Reviewed By: oulgen
Differential Revision: D25640887
fbshipit-source-id: 823edcae1cb7c4ddb569637c7ba15f8fb6577e2c
Summary:
The only purpose of making Shapes::idx a native call was to force it to be inlined via FCallBuiltin so that we could use the offset lookup optimization for these array accesses.
Now that FCallBuiltin is dead, we'll never do this profiling. That means a pure Hack implementation will work as well as the builtin.
Reviewed By: oulgen
Differential Revision: D25640887
fbshipit-source-id: 823edcae1cb7c4ddb569637c7ba15f8fb6577e2c
19 files changed: