Remove polymorphic variant Typing_defs.dependent_type
commitf0a313c0a26925355802413169124cb39ad637b6
authorJake Bailey (Hacklang) <jakebailey@fb.com>
Mon, 12 Aug 2019 20:41:11 +0000 (12 13:41 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 12 Aug 2019 20:45:10 +0000 (12 13:45 -0700)
tree10f67b7ed8c8ea0537a59aaa19d93aa352358f3c
parent290151f8a19efeceae5007230877785cc7a333db
Remove polymorphic variant Typing_defs.dependent_type

Summary: As in D16751979, this polymorphic variant isn't strictly necessary--a regular variant type serves our needs just fine, and we don't yet have support for polymorphic variants in generated Rust interop. As noted in the summary of D16751979, it would be possible to generate interop code for polymorphic variants, but since we do not use them extensively (or in ways that are not expressible using regular variant types), it is easier to get rid of the few instances we do have.

Reviewed By: shiqicao

Differential Revision: D16767537

fbshipit-source-id: 7a812c2bcc9841524659541458301ba58bd12813
12 files changed:
hphp/hack/src/typing/pp_type.ml
hphp/hack/src/typing/tast_check/enforceable_hint_check.ml
hphp/hack/src/typing/tast_check/reified_check.ml
hphp/hack/src/typing/typing_defs.ml
hphp/hack/src/typing/typing_dependent_type.ml
hphp/hack/src/typing/typing_print.ml
hphp/hack/src/typing/typing_reactivity.ml
hphp/hack/src/typing/typing_solver.ml
hphp/hack/src/typing/typing_subtype.ml
hphp/hack/src/typing/typing_taccess.ml
hphp/hack/src/typing/typing_utils.ml
hphp/hack/src/typing/typing_xhp.ml