| commit | efa5ea4b46bae527463758ad10761866670ce803 | |
| author | Keith Miller <kdm@fb.com> | |
| Fri, 13 Jun 2014 17:48:17 +0000 (13 10:48 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Mon, 23 Jun 2014 23:00:18 +0000 (23 16:00 -0700) | ||
| tree | 20905529e6d875978c61d08980d965a8938a52da | treesnapshot (tar.gz zip) |
| parent | d9c692225810d04fc3bf99a035c636237c3c814a | commitdiff |
Converting ArrayObjcets to an array was not working correctly when the STD_PROP_LIST flag was set
Summary: The STD_PROP_LIST flag for array objects should treat properties of the array object as if they are the storage of the class. When we were converting to an array the internal storage array was still being copied. This also a problem with json_encoding where the properties were not being encoded. Fixes #2139
Reviewed By: @ptarjan
Differential Revision: D1382324
Summary: The STD_PROP_LIST flag for array objects should treat properties of the array object as if they are the storage of the class. When we were converting to an array the internal storage array was still being copied. This also a problem with json_encoding where the properties were not being encoded. Fixes #2139
Reviewed By: @ptarjan
Differential Revision: D1382324
| hphp/runtime/base/object-data.cpp | diffblobblamehistory | |
| hphp/runtime/base/object-data.h | diffblobblamehistory | |
| hphp/test/slow/array_object/json_encode.php | [new file with mode: 0644] | blob |
| hphp/test/slow/array_object/json_encode.php.expect | [new file with mode: 0644] | blob |