Improve substr zend compatibility
commitef209b96d389da335a9f1e9af7569869253961a6
authorjaver <javer@argentum.ua>
Fri, 6 Sep 2013 20:48:28 +0000 (6 13:48 -0700)
committerSara Golemon <sgolemon@fb.com>
Fri, 6 Sep 2013 23:18:39 +0000 (6 16:18 -0700)
treee23b9627290b8d3fef1106086d1219fe4db4fbb9
parent0bd3a87e85b4716c386563ecc6811f4b45b54f8b
Improve substr zend compatibility

Fixed issues with negative and out of bounds start position
and length

Closes #1031

Differential Revision: D959015
hphp/runtime/base/zend-string.cpp
hphp/test/zend/bad/ext-standard-strings/bug45166.php [deleted file]
hphp/test/zend/good/ext-standard-strings/bug45166.php [new file with mode: 0644]
hphp/test/zend/good/ext-standard-strings/bug45166.php.expectf [moved from hphp/test/zend/bad/ext-standard-strings/bug45166.php.expectf with 100% similarity]
hphp/test/zend/good/ext-standard-strings/substr.php [moved from hphp/test/zend/bad/ext-standard-strings/substr.php with 99% similarity]
hphp/test/zend/good/ext-standard-strings/substr.php.expectf [moved from hphp/test/zend/bad/ext-standard-strings/substr.php.expectf with 100% similarity]