| commit | ef18aa7e94284e866fa06bf3d58d3173457ad3f9 | |
| author | Oguz Ulgen <oulgen@fb.com> | |
| Fri, 26 Apr 2019 07:45:00 +0000 (26 00:45 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 26 Apr 2019 07:48:48 +0000 (26 00:48 -0700) | ||
| tree | 93d9e1cff76101ff7edb95bfc22725d9fd8fd1e5 | treesnapshot (tar.gz zip) |
| parent | 5a027a0783dad8657e5b2fcefa483ddff8baeaab | commitdiff |
Add FPushClsMethodR* as an optimizations for ReifiedName + FPushClsMethod*
Summary: This diff adds a new bytecode to optimize the combination of `ReifiedName` + `FPushClsMethod` since for reified generics we do know the name of the function statically but using `FPushClsMethod` was preventing us from using this static knowledge. Also, according to strobelight data, most of the time is spend on generating the string from reified generics but in this case we do not need to do that, so this diff elides this string creation.
Reviewed By: jano
Differential Revision: D14932066
fbshipit-source-id: b31c7b4bae6a07e1fedb6c3c4cb4fde42e6bbe69
Summary: This diff adds a new bytecode to optimize the combination of `ReifiedName` + `FPushClsMethod` since for reified generics we do know the name of the function statically but using `FPushClsMethod` was preventing us from using this static knowledge. Also, according to strobelight data, most of the time is spend on generating the string from reified generics but in this case we do not need to do that, so this diff elides this string creation.
Reviewed By: jano
Differential Revision: D14932066
fbshipit-source-id: b31c7b4bae6a07e1fedb6c3c4cb4fde42e6bbe69
20 files changed: