Make Array(ArrayData*) constructor explicit
commiteef34b47b39a456810817b1c53230272a1b530e5
authorBert Maher <bertrand@fb.com>
Mon, 31 Mar 2014 20:50:08 +0000 (31 13:50 -0700)
committerSara Golemon <sgolemon@fb.com>
Wed, 2 Apr 2014 16:14:02 +0000 (2 09:14 -0700)
treeeb93e742ea511d605bad2493a7c058899311655b
parentf3a96ede0c40dad319a622fbb7748d4e6f1d6a6a
Make Array(ArrayData*) constructor explicit

As a bonus this found lots of places where we should use the
marginally-more-efficient ArrayInit::toArray instead of
ArrayInit::create followed by an implicit conversion.

Reviewed By: @markw65

Differential Revision: D1248820
30 files changed:
hphp/runtime/base/apc-local-array.cpp
hphp/runtime/base/datetime.cpp
hphp/runtime/base/exceptions.cpp
hphp/runtime/base/file.cpp
hphp/runtime/base/program-functions.cpp
hphp/runtime/base/timestamp.cpp
hphp/runtime/base/type-array.cpp
hphp/runtime/base/type-array.h
hphp/runtime/base/type-variant.cpp
hphp/runtime/base/type-variant.h
hphp/runtime/ext/VariantController.h
hphp/runtime/ext/apache/ext_apache.cpp
hphp/runtime/ext/asio/gen_array_wait_handle.cpp
hphp/runtime/ext/ext_array.cpp
hphp/runtime/ext/ext_collections.cpp
hphp/runtime/ext/ext_datetime.cpp
hphp/runtime/ext/ext_error.cpp
hphp/runtime/ext/ext_file.cpp
hphp/runtime/ext/ext_function.cpp
hphp/runtime/ext/ext_memcache.cpp
hphp/runtime/ext/ext_pdo.cpp
hphp/runtime/ext/ext_process.cpp
hphp/runtime/ext/ext_socket.cpp
hphp/runtime/ext/ext_spl.cpp
hphp/runtime/ext/ext_sqlite3.cpp
hphp/runtime/ext/imagick/ext_imagick.h
hphp/runtime/ext/imagick/imagick.cpp
hphp/runtime/ext/imagick/imagickpixel.cpp
hphp/runtime/ext/session/ext_session.cpp
hphp/runtime/ext/zip/ext_zip.cpp