Clean up StringIntern
commitee341093e4e44d8e5ba7d27080bd9af3582d5047
authorAaron Orenstein <aorenste@fb.com>
Wed, 7 Sep 2022 14:14:42 +0000 (7 07:14 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 7 Sep 2022 14:14:42 +0000 (7 07:14 -0700)
tree3ff50d8dbf6acea6f7c05507d520a1e89773f2f1
parent79f8c0c0cba2300c7b5766b9a6fc0ecedf7d7735
Clean up StringIntern

Summary: Remove all direct support for Str from the IR's StringIntern.  Instead StringIntern only knows how to intern bytes (and strings).  Added a StringCache to ir_to_bc to cache Strs that are converted in the process of building the HackCUnit.

Reviewed By: edwinsmith

Differential Revision: D39174068

fbshipit-source-id: dd7715cac7bd095356e419c5197dc4ad0e76f5e6
25 files changed:
hphp/hack/Cargo.lock
hphp/hack/src/hackc/ir/conversions/bc_to_ir/context.rs
hphp/hack/src/hackc/ir/conversions/bc_to_ir/func.rs
hphp/hack/src/hackc/ir/conversions/bc_to_ir/instrs.rs
hphp/hack/src/hackc/ir/conversions/bc_to_ir/types.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/Cargo.toml
hphp/hack/src/hackc/ir/conversions/ir_to_bc/class.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/convert.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/emitter.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/func.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/lib.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/pusher.rs
hphp/hack/src/hackc/ir/conversions/ir_to_bc/strings.rs [new file with mode: 0644]
hphp/hack/src/hackc/ir/conversions/ir_to_bc/types.rs
hphp/hack/src/hackc/ir/ir_core/Cargo.toml
hphp/hack/src/hackc/ir/ir_core/newtype.rs
hphp/hack/src/hackc/ir/ir_core/string_intern.rs
hphp/hack/src/hackc/ir/ir_core/types.rs
hphp/hack/src/hackc/ir/ir_core/unit.rs
hphp/hack/src/hackc/ir/passes/Cargo.toml
hphp/hack/src/hackc/ir/passes/ssa.rs
hphp/hack/src/hackc/ir/print/formatters.rs
hphp/hack/src/hackc/ir/print/lib.rs
hphp/hack/src/hackc/ir/print/print.rs
hphp/hack/src/hackc/ir/verify/verify.rs