Propagate errors through datastore::Store trait
commited3245837af83d7443b098363a600baa9f54458b
authorJake Bailey <jakebailey@fb.com>
Thu, 19 May 2022 16:37:18 +0000 (19 09:37 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 19 May 2022 16:37:18 +0000 (19 09:37 -0700)
tree6eef96a270d2369c638613419941190b7322bddd
parentffaef40c554270611d80505bbe4d7f22920e619a
Propagate errors through datastore::Store trait

Summary: Make Store methods return an `anyhow::Result` to allow fallible datastore implementations. Remove `.unwrap()`s in serde_store and naming_table now that the errors can be propagated up.

Reviewed By: shayne-fletcher

Differential Revision: D36496645

fbshipit-source-id: 7bd991a0d23949f0fe0c4a4cd33147eac8c97972
16 files changed:
hphp/hack/src/providers/hackrs_provider_backend/naming_table.rs
hphp/hack/src/providers/rust_provider_backend_ffi.rs
hphp/hack/src/rupro/datastore/changes_store.rs
hphp/hack/src/rupro/datastore/datastore.rs
hphp/hack/src/rupro/datastore/delta_store.rs
hphp/hack/src/rupro/datastore/non_evicting.rs
hphp/hack/src/rupro/decl_folded_class_ffi.rs
hphp/hack/src/rupro/hackrs/folded_decl_provider.rs
hphp/hack/src/rupro/hackrs/folded_decl_provider/provider.rs
hphp/hack/src/rupro/hackrs/shallow_decl_provider.rs
hphp/hack/src/rupro/hackrs/shallow_decl_provider/provider.rs
hphp/hack/src/rupro/hackrs/shallow_decl_provider/store.rs
hphp/hack/src/rupro/hackrs_test_utils/serde_store.rs
hphp/hack/src/rupro/hackrs_test_utils/store.rs
hphp/hack/src/rupro/naming_provider/naming_provider.rs
hphp/hack/src/rupro/stc_ffi.rs