Move all enums/typedefs into common
commitecfc5940d230d6e43a77151a1db1699330fd9d07
authorTed Spence <tspence@fb.com>
Wed, 17 Apr 2019 17:15:48 +0000 (17 10:15 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Wed, 17 Apr 2019 17:19:55 +0000 (17 10:19 -0700)
treed9c91d8d56d0ffe8d9106bb0e48a16a6020a2542
parentf51193d79f36d2bae521cbf2723a04d01be5c72c
Move all enums/typedefs into common

Summary:
In order to facilitate sharing typedefs between the index builder and the symbol service, this diff creates a single library, "//hphp/hack/src/search:common", which contains a single ML file, "searchUtils.ml", that contains:
* All search-related typedefs
* All autocomplete-related typedefs
* Conversion methods that take integers and switch back to kinds

I updated all of the names to refer to the new designation, "SymbolIndex", suggested by Jake's previous diff.

Finally, updated all the code in HH and global_index_builder to use the typedefs from a single place.

Reviewed By: pittsw

Differential Revision: D14894298

fbshipit-source-id: 7b28248f76bb103e13fed7073c2ea7dde1d878ca
16 files changed:
hphp/hack/src/client/clientLsp.ml
hphp/hack/src/facts/symbols/indexBuilder.ml
hphp/hack/src/facts/symbols/indexBuilderTypes.ml [deleted file]
hphp/hack/src/facts/symbols/jsonIndexWriter.ml
hphp/hack/src/facts/symbols/sqliteIndexWriter.ml
hphp/hack/src/facts/symbols/textIndexWriter.ml
hphp/hack/src/search/hackSearchService.ml
hphp/hack/src/search/searchUtils.ml
hphp/hack/src/search/symbolIndex.ml
hphp/hack/src/search/symbolIndex.mli
hphp/hack/src/server/autocompleteService.ml
hphp/hack/src/server/ffpAutocompleteGlobals.ml
hphp/hack/src/server/searchServiceRunner.ml
hphp/hack/src/server/serverCommandTypes.ml
hphp/hack/src/server/serverLazyInit.ml
hphp/hack/src/server/serverSearch.ml