| commit | ec0632ca3570f19a87a99dda51c84ca569edbfde | |
| author | Jeffrey Tan <jeffreytan@fb.com> | |
| Wed, 8 Apr 2020 19:01:40 +0000 (8 12:01 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 8 Apr 2020 19:09:01 +0000 (8 12:09 -0700) | ||
| tree | b56b3341db52b6cd5a48c86465696c23beda2cdb | treesnapshot (tar.gz zip) |
| parent | 659eaf7c4606df2d7b60f51312787a9e46a3f701 | commitdiff |
Load naming table from saved state in hh_bulk_check
Summary:
Previous diff used Lwt which conflicts with `future.ml`. This new version uses future instead.
Before this diff, `hh_bulk_check` tool requires the caller to provide an up-to-date naming table which may not be convenient for users.
This diff enables `hh_bulk_check` to self generate a naming table. It does so with code to download naming table from saved state and then apply changed files since saved state to the naming table. Most of the logic is borrowed from `hh_lite` tool. Eventually, I hope we can share the code in a more usable way instead of copying it. Long term, we can even consider merging `hh_lite` and `hh_bulk_check` tool.
Reviewed By: 2BitSalute
Differential Revision: D20878723
fbshipit-source-id: 9881c2bdd0c474fea1920e4c38afa9a386993e7e
Summary:
Previous diff used Lwt which conflicts with `future.ml`. This new version uses future instead.
Before this diff, `hh_bulk_check` tool requires the caller to provide an up-to-date naming table which may not be convenient for users.
This diff enables `hh_bulk_check` to self generate a naming table. It does so with code to download naming table from saved state and then apply changed files since saved state to the naming table. Most of the logic is borrowed from `hh_lite` tool. Eventually, I hope we can share the code in a more usable way instead of copying it. Long term, we can even consider merging `hh_lite` and `hh_bulk_check` tool.
Reviewed By: 2BitSalute
Differential Revision: D20878723
fbshipit-source-id: 9881c2bdd0c474fea1920e4c38afa9a386993e7e