| commit | eadecb5bdd6311029e5d4361f80b654e92b20296 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Wed, 22 Jan 2020 19:52:00 +0000 (22 11:52 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 22 Jan 2020 20:23:05 +0000 (22 12:23 -0800) | ||
| tree | 6f1bca9ea0f5c7f499cd8bda168c663558c57372 | treesnapshot (tar.gz zip) |
| parent | 3ba601d33677c0202ea952b6235204a845b4114f | commitdiff |
test completion snippets
Summary:
clientLsp will send snippets to clients that support them, or plain text to other clients.
Our integration tests (prior to this diff) only tested the "plain text" path.
But our major clients (VSCode, Atom) support snippets.
This diff changes our integration tests to exercise the snippet path.
(I could have made two separate integration test paths, one of which tested snippets and one which didn't. But that seemed like too much work).
Ultimate goal: a user reported that we're sending the wrong snippets, because we haven't escaped $ in them, and VSCode rightly declines to show our snippets.
Reviewed By: arxanas
Differential Revision: D19509477
fbshipit-source-id: 4a1e8a99c0c27a8fd04761579f33736abc27662f
Summary:
clientLsp will send snippets to clients that support them, or plain text to other clients.
Our integration tests (prior to this diff) only tested the "plain text" path.
But our major clients (VSCode, Atom) support snippets.
This diff changes our integration tests to exercise the snippet path.
(I could have made two separate integration test paths, one of which tested snippets and one which didn't. But that seemed like too much work).
Ultimate goal: a user reported that we're sending the wrong snippets, because we haven't escaped $ in them, and VSCode rightly declines to show our snippets.
Reviewed By: arxanas
Differential Revision: D19509477
fbshipit-source-id: 4a1e8a99c0c27a8fd04761579f33736abc27662f
| hphp/hack/test/integration/test_lsp.py | diffblobblamehistory | |
| hphp/hack/test/integration/utils.py | diffblobblamehistory |