| commit | ea9ad1da4dc1cb157299137f9b8fcefcd8467965 | |
| author | Alexey Toptygin <alexeyt@fb.com> | |
| Mon, 24 Sep 2018 18:22:58 +0000 (24 11:22 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 24 Sep 2018 18:33:51 +0000 (24 11:33 -0700) | ||
| tree | a0cdd2306fe15b4f74c361142c79327dea0e0446 | treesnapshot (tar.gz zip) |
| parent | 16d4a79b0518d1fd0885d869ea8f604b4e9e6f4c | commitdiff |
Allow systemlib to use FThrowOnRefMismatch calling convention.
Summary:
The FIsParamByRef calling convention always results in bytecodes producing refs in one branch. We are trying to forbid bytecodes producing refs in the bodies of __Rx functions, so __Rx functions must use the FThrowOnRefMismatch calling convention. Systemlib was wholesale opted out of the FThrowOnRefMismatch calling convention.
Add call-site ref annotations where they are missing in systemlib, stop opting systemlib out of the FThrowOnRefMismatch calling convention, and convert systemlib files where we declared any functions __Rx from <?php to <?hh if needed.
Reviewed By: markw65
Differential Revision: D10001081
fbshipit-source-id: 62255c0f8449882e3de5090033dc46be6e337711
Summary:
The FIsParamByRef calling convention always results in bytecodes producing refs in one branch. We are trying to forbid bytecodes producing refs in the bodies of __Rx functions, so __Rx functions must use the FThrowOnRefMismatch calling convention. Systemlib was wholesale opted out of the FThrowOnRefMismatch calling convention.
Add call-site ref annotations where they are missing in systemlib, stop opting systemlib out of the FThrowOnRefMismatch calling convention, and convert systemlib files where we declared any functions __Rx from <?php to <?hh if needed.
Reviewed By: markw65
Differential Revision: D10001081
fbshipit-source-id: 62255c0f8449882e3de5090033dc46be6e337711
39 files changed: