| commit | ea792922fd5462a77c45482685d61d0999424876 | |
| author | Joseph Griego <jgriego@fb.com> | |
| Fri, 14 Feb 2020 19:15:44 +0000 (14 11:15 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 14 Feb 2020 19:37:32 +0000 (14 11:37 -0800) | ||
| tree | 037cc90b341de95285c4f5b9ee8a5678c1240cdd | treesnapshot (tar.gz zip) |
| parent | da5ce2da14f87d7e16ac63746813006367f7c39d | commitdiff |
Fix opt_array_mark_legacy
Summary:
These should have had the catch block installed;
I don't think it is a significant issue since we don't emit the optimizations when irgen-ing a `NativeImpl` and that's the circumstance under which we will assert without the additional magic that make_opt_catch provides.
We do neglect to decref the params without before this patch though, which should be addressed.
Differential Revision: D19751269
fbshipit-source-id: 90efe5e7e9039e2ba5106f9847d5079303c13105
Summary:
These should have had the catch block installed;
I don't think it is a significant issue since we don't emit the optimizations when irgen-ing a `NativeImpl` and that's the circumstance under which we will assert without the additional magic that make_opt_catch provides.
We do neglect to decref the params without before this patch though, which should be addressed.
Differential Revision: D19751269
fbshipit-source-id: 90efe5e7e9039e2ba5106f9847d5079303c13105
| hphp/runtime/vm/jit/irgen-builtin.cpp | diffblobblamehistory |