flip default of disable_lval_as_an_expression
commite9bf0c598db5ff00ffc80aae6c565488716f8ec2
authorFred Emmott <fe@fb.com>
Tue, 17 Dec 2019 22:24:23 +0000 (17 14:24 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 17 Dec 2019 22:26:42 +0000 (17 14:26 -0800)
tree7e14b3783cb4cbc518415a9e28e61805e436ed9e
parent84146cb35166eb83caa572a7d14f8f33ef2ae71b
flip default of disable_lval_as_an_expression

Reviewed By: vassilmladenov

Differential Revision: D18606016

fbshipit-source-id: f192187ebc5cdfca102aeb103aab2846e5d2d7ad
66 files changed:
hphp/hack/src/options/globalOptions.ml
hphp/hack/test/typecheck/akempty/akempty_promotion_7.php.exp
hphp/hack/test/typecheck/assign_to_function_invocation.php.exp
hphp/hack/test/typecheck/assignment_sequencing/assign_in_cond.php.exp
hphp/hack/test/typecheck/assignment_sequencing/assign_in_conditional.php.exp
hphp/hack/test/typecheck/assignment_sequencing/assign_in_conj_disj_of_conditionals.php.exp
hphp/hack/test/typecheck/assignment_sequencing/binop_increment.php.exp
hphp/hack/test/typecheck/assignment_sequencing/binop_rw.php.exp
hphp/hack/test/typecheck/assignment_sequencing/binop_ww.php.exp
hphp/hack/test/typecheck/assignment_sequencing/double_assign.php.exp
hphp/hack/test/typecheck/assignment_sequencing/indexing_increment.php.exp
hphp/hack/test/typecheck/assignment_sequencing/lambda_default_arg_increment.php.exp
hphp/hack/test/typecheck/assignment_sequencing/list_double_increment.php.exp
hphp/hack/test/typecheck/assignment_sequencing/list_increment_nested.php.exp
hphp/hack/test/typecheck/assignment_sequencing/list_rhs_increment.php.exp
hphp/hack/test/typecheck/assignment_sequencing/ok_sequencing.php
hphp/hack/test/typecheck/assignment_sequencing/switch_case_assn.php.exp
hphp/hack/test/typecheck/assignment_sequencing/unseq_default_arg.php.exp
hphp/hack/test/typecheck/compile_test_array.php
hphp/hack/test/typecheck/control_flow/do_assign_in_invariant.php.exp
hphp/hack/test/typecheck/control_flow/eif.php
hphp/hack/test/typecheck/control_flow/eif.php.exp
hphp/hack/test/typecheck/control_flow/for_assign_in_invariant.php.exp
hphp/hack/test/typecheck/control_flow/while_assign_in_invariant.php.exp
hphp/hack/test/typecheck/defined/assign_in_conditional.php.exp
hphp/hack/test/typecheck/defined/assign_in_eif.php.exp
hphp/hack/test/typecheck/defined/condition_conjunction.php.exp
hphp/hack/test/typecheck/defined/conditional.php.exp
hphp/hack/test/typecheck/defined/conditional.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/defined/conditional_ok.php.exp
hphp/hack/test/typecheck/defined/if_func_call.php.exp
hphp/hack/test/typecheck/defined/if_func_call_2.php.exp
hphp/hack/test/typecheck/do2.php.exp
hphp/hack/test/typecheck/do_while_condition_typechange.php.exp
hphp/hack/test/typecheck/eif_define_var.php.exp
hphp/hack/test/typecheck/error_messages/inc_dynamic.php.exp
hphp/hack/test/typecheck/ffp/yield_bad2.php.exp
hphp/hack/test/typecheck/finally_basic.php
hphp/hack/test/typecheck/finally_basic.php.exp
hphp/hack/test/typecheck/finally_naming.php
hphp/hack/test/typecheck/finally_naming.php.exp
hphp/hack/test/typecheck/for.php
hphp/hack/test/typecheck/for_condition_typechange.php.exp
hphp/hack/test/typecheck/for_multiexpression_condition_with_typechange.php.exp
hphp/hack/test/typecheck/if_assign.php.exp
hphp/hack/test/typecheck/list_array_assign.php.exp
hphp/hack/test/typecheck/list_pair_assign.php.exp
hphp/hack/test/typecheck/multi_assign.php.exp
hphp/hack/test/typecheck/new_inference/eager_solve/array_append_good.php
hphp/hack/test/typecheck/null_coalesce_assignment/bad_lvalue.php.exp
hphp/hack/test/typecheck/null_coalesce_assignment/null_coalesce_assignment_2.php
hphp/hack/test/typecheck/nullsafe/nullsafe-call-1.php
hphp/hack/test/typecheck/parse_error_loc_else.php
hphp/hack/test/typecheck/parse_error_loc_else.php.exp
hphp/hack/test/typecheck/pipe_operator_containing_assignment.php.exp
hphp/hack/test/typecheck/postfix_parse3.php.exp
hphp/hack/test/typecheck/refinements/assign_in_cond.php.exp
hphp/hack/test/typecheck/test_subtyping.php.exp
hphp/hack/test/typecheck/typing_fail_instance_of.php
hphp/hack/test/typecheck/using/using_bad_async.php.exp
hphp/hack/test/typecheck/using/using_bad_syntax.php
hphp/hack/test/typecheck/using/using_bad_syntax.php.exp
hphp/hack/test/typecheck/using/using_bad_syntax_2.php
hphp/hack/test/typecheck/using/using_bad_syntax_3.php
hphp/hack/test/typecheck/using/using_bad_syntax_3.php.exp
hphp/hack/test/typecheck/while_condition_typechange.php.exp