Kill CollectionOpts::TrackConstantArraysnightly-2019.04.28
commite9b7a5f950f34ff1e1339d02de74d8a6f8e833ec
authorMark Williams <mwilliams@fb.com>
Sun, 28 Apr 2019 00:40:42 +0000 (27 17:40 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Sun, 28 Apr 2019 00:45:01 +0000 (27 17:45 -0700)
tree71de4a06e38b8ca3fadb3f02f13493e3f731be8d
parent54b8f993e2f68c7f89b8fbeb77209e4e4b1a71ef
Kill CollectionOpts::TrackConstantArrays

Summary:
This was used to prevent doing expensive array type tracking during
the constant pass analysis phase, since it would be redone during the
optimize phase.

Now that the analysis phase rewrites them anyway, we don't even need an
optimization phase for the constant pass anymore, so we can drop the flag.

Reviewed By: ricklavoie

Differential Revision: D15113882

fbshipit-source-id: eb446ecaef4796cfa9ca9ad496d30d3d441868a8
hphp/hhbbc/analyze.cpp
hphp/hhbbc/analyze.h
hphp/hhbbc/dce.cpp
hphp/hhbbc/index.cpp
hphp/hhbbc/interp-state.h
hphp/hhbbc/interp.cpp
hphp/hhbbc/optimize.cpp
hphp/hhbbc/stats.cpp
hphp/hhbbc/whole-program.cpp