| commit | e8a85370acfeef2c485f17dba29daacfc645da8b | |
| author | Michael Christensen <mchristensen@fb.com> | |
| Mon, 22 Aug 2022 17:43:46 +0000 (22 10:43 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 22 Aug 2022 17:43:46 +0000 (22 10:43 -0700) | ||
| tree | 4f3d631700060f531ba14519fbec9a208e590b68 | treesnapshot (tar.gz zip) |
| parent | 032d3028e16824f0b5028f46ad2e54ef9bcd6bfb | commitdiff |
Quit if compile fails
Summary:
Using `hhvm_wrapper.php -c` causes two separate commands to be invoked. When the first (compiling the repo) fails, it would be helpful for the script to immediately quit so that it's more obvious it failed in the first step.
When printing the command, we can still continue, since although the first has been run, we won't be running the second (since the expectation is for the user to probably run the first again along with the second?).
Reviewed By: ricklavoie
Differential Revision: D38909575
fbshipit-source-id: 0d1274253acdeb2d765af40b9792355730fc17a3
Summary:
Using `hhvm_wrapper.php -c` causes two separate commands to be invoked. When the first (compiling the repo) fails, it would be helpful for the script to immediately quit so that it's more obvious it failed in the first step.
When printing the command, we can still continue, since although the first has been run, we won't be running the second (since the expectation is for the user to probably run the first again along with the second?).
Reviewed By: ricklavoie
Differential Revision: D38909575
fbshipit-source-id: 0d1274253acdeb2d765af40b9792355730fc17a3
| hphp/tools/hhvm_wrapper.php | diffblobblamehistory |