| commit | e82e7bd1fb0335afcfe45fb597f19fd260b1f9b5 | |
| author | Arnab De <arnabde@fb.com> | |
| Sat, 16 Apr 2022 04:32:01 +0000 (15 21:32 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 16 Apr 2022 04:32:01 +0000 (15 21:32 -0700) | ||
| tree | bc1a6c498df26afb57ac40f9c1da239805af2957 | treesnapshot (tar.gz zip) |
| parent | 4d4f974fe1616e15b02e36e4cdba4a568b44033c | commitdiff |
New bytecode for static method calls with dynamic class name
Summary: We should raise a warning for static method calls with dynamic class names if the class name is a string. Currently the class is already resolved when we execute a `FCallClsMethod`, therefore it cannot differentiate between a string class name and lazy class class name. Create a new bytecode for static method calls with dynamic class names. This bytecode resolves the class name itself and raises a warning if it is a string and appropriate options are set. If the method name is dynamic, we use the existing `FCallClsMethod` bytecode.
Reviewed By: periodic1236
Differential Revision: D35412118
fbshipit-source-id: 3863bae228dedffcebe79cba452c0f0255c3191b
Summary: We should raise a warning for static method calls with dynamic class names if the class name is a string. Currently the class is already resolved when we execute a `FCallClsMethod`, therefore it cannot differentiate between a string class name and lazy class class name. Create a new bytecode for static method calls with dynamic class names. This bytecode resolves the class name itself and raises a warning if it is a string and appropriate options are set. If the method name is dynamic, we use the existing `FCallClsMethod` bytecode.
Reviewed By: periodic1236
Differential Revision: D35412118
fbshipit-source-id: 3863bae228dedffcebe79cba452c0f0255c3191b
18 files changed: