| commit | e77699555b0b6da9b61b129aa13206734602a9e7 | |
| author | Alma Thaler <almathaler@fb.com> | |
| Tue, 5 Jul 2022 18:13:28 +0000 (5 11:13 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 5 Jul 2022 18:13:28 +0000 (5 11:13 -0700) | ||
| tree | b69155a080459b43f6a81f5faababa00b6d1753c | treesnapshot (tar.gz zip) |
| parent | a608af12e208b08ef33d2b7bd654c4c7a442faa2 | commitdiff |
Adding class methods
Summary:
Added support for assembling methods, which are almost identical to functions but not completely (different flags and fields, like `Visibility`). Can now assemble snippets like:
```
.method {}{} [public static] (12,14) <"" N > f() {
.srcloc 13:10,13:16;
String "Foo\n"
.srcloc 13:5,13:17;
Print
.srcloc 13:5,13:17;
PopC
.srcloc 14:4,14:4;
Null
RetC
}
```
Also added a convenience function `expect_identfier_into_ffi_str`. A goal for the future is to increase code cleanup -- in the next Diff more on this,
Can now assemble 297/904 of the files in quick.
Reviewed By: aorenste
Differential Revision: D37555057
fbshipit-source-id: 9e98602bb79e6efd3f754b7aefb6fb59daa43443
Summary:
Added support for assembling methods, which are almost identical to functions but not completely (different flags and fields, like `Visibility`). Can now assemble snippets like:
```
.method {}{} [public static] (12,14) <"" N > f() {
.srcloc 13:10,13:16;
String "Foo\n"
.srcloc 13:5,13:17;
.srcloc 13:5,13:17;
PopC
.srcloc 14:4,14:4;
Null
RetC
}
```
Also added a convenience function `expect_identfier_into_ffi_str`. A goal for the future is to increase code cleanup -- in the next Diff more on this,
Can now assemble 297/904 of the files in quick.
Reviewed By: aorenste
Differential Revision: D37555057
fbshipit-source-id: 9e98602bb79e6efd3f754b7aefb6fb59daa43443
| hphp/hack/src/hackc/hackc/assemble.rs | diffblobblamehistory | |
| hphp/hack/src/hackc/hhvm_cxx/hhvm_types/hhvm_types_ffi.rs | diffblobblamehistory |