Fixes for Code Model for query expressions.
commite687e1d44fec719826bbe95bdfbcb35c77260869
authorHerman Venter <hermanv@fb.com>
Sat, 8 Feb 2014 00:50:11 +0000 (7 16:50 -0800)
committerSara Golemon <sgolemon@fb.com>
Mon, 10 Feb 2014 17:44:12 +0000 (10 09:44 -0800)
treeb0c51eb77a255be36bab25d34c9f99d08f4aac06
parent288114d00ba4bdc472e858a3b7d11aa4f4713699
Fixes for Code Model for query expressions.

The serialization code for query expressions did not match the actual code model in a various places. Also, the model for into expressions was incorrect. Also changed the way that order by AST nodes are constructed because the tokens for ascending and descending always report 0 as their token id value.

Reviewed By: @paroski

Differential Revision: D1157921
22 files changed:
hphp/compiler/expression/join_clause.cpp
hphp/compiler/expression/ordering.cpp
hphp/compiler/expression/ordering.h
hphp/compiler/expression/query_expression.cpp
hphp/compiler/expression/simple_query_clause.cpp
hphp/compiler/parser/parser.cpp
hphp/test/quick/phinq/from1.php.expect
hphp/test/quick/phinq/from2.php.expect
hphp/test/quick/phinq/groupby1.php.expect
hphp/test/quick/phinq/groupby2.php.expect
hphp/test/quick/phinq/groupby3.php.expect
hphp/test/quick/phinq/into1.php.expect
hphp/test/quick/phinq/into2.php.expect
hphp/test/quick/phinq/join1.php.expect
hphp/test/quick/phinq/join2.php.expect
hphp/test/quick/phinq/join3.php.expect
hphp/test/quick/phinq/let1.php.expect
hphp/test/quick/phinq/orderby1.php.expect
hphp/test/quick/phinq/orderby2.php.expect
hphp/test/quick/phinq/select1.php.expect
hphp/test/quick/phinq/select2.php.expect
hphp/test/quick/phinq/where1.php.expect