| commit | e67e31db924a9f88331fd61ab3c1dd9210a7144c | |
| author | Owen Yamauchi <oyamauchi@fb.com> | |
| Wed, 4 Sep 2013 01:08:15 +0000 (3 18:08 -0700) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Tue, 17 Sep 2013 18:08:11 +0000 (17 11:08 -0700) | ||
| tree | 3e589d03a6e068f60f557d50e312aa85353e9db0 | treesnapshot (tar.gz zip) |
| parent | dbe929ba4e879f24cd3bace3f36f1d8b8c559c8b | commitdiff |
Move most remaining service request code into its own module
This moves the emitBindJmp, emitBindJcc, and emitBindCall functions, as
well as some supporting players, into a new module
service-requests-x64.cpp. The two functions freeRequestStub and
getFreeStub are still in tx64, but I think that makes sense.
The way this structure is turning out still doesn't sit well with me,
but I can't quite pin down why. At least now all the nasty-looking
helpers for the emitBind* functions are behind a clean module boundary,
and the external interface (in service-requests-x64.h) is pretty clean.
Getting the new file compiling forced me to clean up some includes, and
move DataBlock up to the HPHP namespace (it was in Transl before).
Reviewed By: @jdelong
Differential Revision: D957725
This moves the emitBindJmp, emitBindJcc, and emitBindCall functions, as
well as some supporting players, into a new module
service-requests-x64.cpp. The two functions freeRequestStub and
getFreeStub are still in tx64, but I think that makes sense.
The way this structure is turning out still doesn't sit well with me,
but I can't quite pin down why. At least now all the nasty-looking
helpers for the emitBind* functions are behind a clean module boundary,
and the external interface (in service-requests-x64.h) is pretty clean.
Getting the new file compiling forced me to clean up some includes, and
move DataBlock up to the HPHP namespace (it was in Transl before).
Reviewed By: @jdelong
Differential Revision: D957725