| commit | e61799850dc836cf7a472edb58b141a209b9c34b | |
| author | Kasper Kopec <kasper@fb.com> | |
| Mon, 18 Jun 2018 06:15:05 +0000 (17 23:15 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 18 Jun 2018 06:26:33 +0000 (17 23:26 -0700) | ||
| tree | 3bea0922880b589c194258feb2f019a561fcad4a | treesnapshot (tar.gz zip) |
| parent | cb684ba316bfaeeba3e76cf162b67f067e6821b8 | commitdiff |
Fix Errors.merge performance
Summary: This was broken in {D7094911}, but (since we don't have that many errors) had no visible impact. We do have many more HH_FIXME's though, but accumulating those actually happened to get broken in exactly the same release by {D7046657}. It was now fixed in {D8253515}, revealing the underlying issue (and making --no-load inits take twice as long as they should).
Reviewed By: CatherineGasnier
Differential Revision: D8384219
fbshipit-source-id: 3fd0e16b07b677fb59d11745d1a7f5b5452f2aba
Summary: This was broken in {D7094911}, but (since we don't have that many errors) had no visible impact. We do have many more HH_FIXME's though, but accumulating those actually happened to get broken in exactly the same release by {D7046657}. It was now fixed in {D8253515}, revealing the underlying issue (and making --no-load inits take twice as long as they should).
Reviewed By: CatherineGasnier
Differential Revision: D8384219
fbshipit-source-id: 3fd0e16b07b677fb59d11745d1a7f5b5452f2aba
| hphp/hack/src/errors/errors.ml | diffblobblamehistory | |
| hphp/hack/test/unit/utils/errors_test.ml | diffblobblamehistory |