| commit | e58bc791317a1c7c4294b0fa371562ae46e4153a | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Thu, 5 Aug 2021 04:01:00 +0000 (4 21:01 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 5 Aug 2021 04:02:23 +0000 (4 21:02 -0700) | ||
| tree | d58c6900669415adef5f0b863bf41792bf627600 | treesnapshot (tar.gz zip) |
| parent | d4c8a50001d3e6b75b051006cec96a4e73cb1916 | commitdiff |
Delete curl_copy_handle and CurlPool builtins
Summary:
cURL handles can share state as an optimization, including DNS caches and SSL IDs. Sharing state leads to thread-safety issues, especially as libcurl uses more caching to win better performance. Right now, HHVM supports three ways of explicitly constructing handles with shared state:
1. Copying a handle (I'm uncertain how much state is shared, but probably some)
1. Named process-global connection pools
1. The CurlShareHandle resource type
We don't use 1 and 2. The code for these kinds of sharing is likely wrong now as a result. Let's eliminate 1 and 2, so that CurlShareHandle is the only API that needs synchronization.
Reviewed By: ricklavoie
Differential Revision: D30109386
fbshipit-source-id: f3adf960ba3abd4d33abb995cf4b58bd8d7dc937
Summary:
cURL handles can share state as an optimization, including DNS caches and SSL IDs. Sharing state leads to thread-safety issues, especially as libcurl uses more caching to win better performance. Right now, HHVM supports three ways of explicitly constructing handles with shared state:
1. Copying a handle (I'm uncertain how much state is shared, but probably some)
1. Named process-global connection pools
1. The CurlShareHandle resource type
We don't use 1 and 2. The code for these kinds of sharing is likely wrong now as a result. Let's eliminate 1 and 2, so that CurlShareHandle is the only API that needs synchronization.
Reviewed By: ricklavoie
Differential Revision: D30109386
fbshipit-source-id: f3adf960ba3abd4d33abb995cf4b58bd8d7dc937