| commit | e5586190a7cd6a270ced3bd60e605ffc54272bc0 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Sat, 27 Apr 2019 13:58:49 +0000 (27 06:58 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Sat, 27 Apr 2019 14:02:27 +0000 (27 07:02 -0700) | ||
| tree | 4152b437702ba46d5f7a8b57ffcf29383d300795 | treesnapshot (tar.gz zip) |
| parent | a968e4e903034a2ebea8a178e1a91279ea3d34a8 | commitdiff |
'poppable' instructions need to be effect_free
Summary:
A sequence such as `NewDArray; PopC` would be eliminated, but the
function (on *that* run through the analyzer) would still be marked as
not effect free. If nothing else caused the function to be
re-analyzed, it would remain effectful, which could prevent folding.
Reviewed By: ricklavoie
Differential Revision: D15103972
fbshipit-source-id: 58ad95909152010daa024865b4eff754758ee087
Summary:
A sequence such as `NewDArray; PopC` would be eliminated, but the
function (on *that* run through the analyzer) would still be marked as
not effect free. If nothing else caused the function to be
re-analyzed, it would remain effectful, which could prevent folding.
Reviewed By: ricklavoie
Differential Revision: D15103972
fbshipit-source-id: 58ad95909152010daa024865b4eff754758ee087
| hphp/hhbbc/interp.cpp | diffblobblamehistory |