| commit | e4e86a0354a2022dc35c2891735fd159fed8dd29 | |
| author | Max Wang <mwang@fb.com> | |
| Thu, 3 Aug 2017 01:21:50 +0000 (2 18:21 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 3 Aug 2017 01:38:26 +0000 (2 18:38 -0700) | ||
| tree | 4d77fc528b6fadd9c1cfd7ce54329b88d4e2ee7c | treesnapshot (tar.gz zip) |
| parent | 2c25e35464ccbc96c8fbfc3b950286043d6d270f | commitdiff |
Fix use after free in ext_objprof
Summary:
We were using a StringData's data immediately after freeing it. In
practice, since we used it immediately afterwards for a hash map lookup,
it probably wasn't symptomatic.
Reviewed By: jano
Differential Revision: D5430652
fbshipit-source-id: f407a0a3ca247cf4590ad0f606af18ca48f86659
Summary:
We were using a StringData's data immediately after freeing it. In
practice, since we used it immediately afterwards for a hash map lookup,
it probably wasn't symptomatic.
Reviewed By: jano
Differential Revision: D5430652
fbshipit-source-id: f407a0a3ca247cf4590ad0f606af18ca48f86659
| hphp/runtime/ext/objprof/ext_objprof.cpp | diffblobblamehistory |