| commit | e4d019d6c409ca34c261f3ea12228880579a260b | |
| author | Owen Yamauchi <oyamauchi@fb.com> | |
| Thu, 21 Nov 2013 23:04:41 +0000 (21 15:04 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Fri, 22 Nov 2013 17:48:57 +0000 (22 09:48 -0800) | ||
| tree | 6b90deaa41a17d2fcc395c250548fb5caec6d67d | treesnapshot (tar.gz zip) |
| parent | 8d601df707b9c6b0d0a604042c80a34901518e96 | commitdiff |
Fix ARM mode bustage that occurred during lockdown
- At some point, the order of arguments to InterpOne got switched
around for no apparent reason in the refcount optimization diff.
- My fix to poly-torture.php got accidentally pseudo-reverted, also in
the refcount optimization diff.
- The type effects of an interped PushL wasn't accounted for properly.
There are still a few more quick tests that crash. Based on their file
names, I think it's all a single root cause. I'll look at those next.
Reviewed By: @jdelong
Differential Revision: D1068766
- At some point, the order of arguments to InterpOne got switched
around for no apparent reason in the refcount optimization diff.
- My fix to poly-torture.php got accidentally pseudo-reverted, also in
the refcount optimization diff.
- The type effects of an interped PushL wasn't accounted for properly.
There are still a few more quick tests that crash. Based on their file
names, I think it's all a single root cause. I'll look at those next.
Reviewed By: @jdelong
Differential Revision: D1068766
| hphp/runtime/vm/jit/code-gen-arm.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/frame-state.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/hhbc-translator.cpp | diffblobblamehistory |