| commit | e49129e2887dba6d2874b3f91b10e2b299d51c26 | |
| author | Max Wang <mwang@fb.com> | |
| Mon, 26 Feb 2018 07:52:38 +0000 (25 23:52 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 26 Feb 2018 08:02:33 +0000 (26 00:02 -0800) | ||
| tree | ea4ccc330e077dfe3ba0abcad928673f016baa9a | treesnapshot (tar.gz zip) |
| parent | c687c3f92924862719b2941c40a8ebdb39d6aa95 | commitdiff |
Add sub-controls for Hack array compat runtime checks
Summary:
Split the runtime checks controlled by HackArrCompatNotices five ways:
- intish string casts
- refs in arrays
- falsey promotion
- comparisons
- everything else
These Check* options still require HackArrCompatNotices to be on, since
optimizations which hide notices are still controlled by the toplevel
HackArrCompatNotices option.
In hphpc and hhbbc, we turn on all the runtime check options if
HackArrCompatNotices is on, in order to avoid constant-folding any
functions where we might want to make runtime checks.
Reviewed By: ricklavoie
Differential Revision: D6902410
fbshipit-source-id: 62e08beb100967251163474a071960f2e01ad921
Summary:
Split the runtime checks controlled by HackArrCompatNotices five ways:
- intish string casts
- refs in arrays
- falsey promotion
- comparisons
- everything else
These Check* options still require HackArrCompatNotices to be on, since
optimizations which hide notices are still controlled by the toplevel
HackArrCompatNotices option.
In hphpc and hhbbc, we turn on all the runtime check options if
HackArrCompatNotices is on, in order to avoid constant-folding any
functions where we might want to make runtime checks.
Reviewed By: ricklavoie
Differential Revision: D6902410
fbshipit-source-id: 62e08beb100967251163474a071960f2e01ad921
43 files changed: