| commit | e31c2a56f4feb1f80b11e6bae01e40596e95fd87 | |
| author | Paul Bissonnette <paulbiss@fb.com> | |
| Fri, 15 Oct 2021 04:44:39 +0000 (14 21:44 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 15 Oct 2021 04:46:00 +0000 (14 21:46 -0700) | ||
| tree | ae585373e129c29033dae32b50f6b403d692246f | treesnapshot (tar.gz zip) |
| parent | 3376cb1c33c6dfe87a3f2b893cafed9f50f15773 | commitdiff |
Fix class loading issue for enum class
Summary:
Both enums (AttrEnum) and enum classes (AttrEnumClass) can include other enums. When we skip this check for enum classes we can't handle enum classes defined out of order during the unit merge process.
(Note: this ignores all push blocking failures!)
Reviewed By: ricklavoie, jano
Differential Revision: D31676573
fbshipit-source-id: 453bfce6219bf4e1df644b4a335eb2cce323d897
Summary:
Both enums (AttrEnum) and enum classes (AttrEnumClass) can include other enums. When we skip this check for enum classes we can't handle enum classes defined out of order during the unit merge process.
(Note: this ignores all push blocking failures!)
Reviewed By: ricklavoie, jano
Differential Revision: D31676573
fbshipit-source-id: 453bfce6219bf4e1df644b4a335eb2cce323d897
| hphp/runtime/vm/class.cpp | diffblobblamehistory | |
| hphp/test/slow/enum-class-order.php | [new file with mode: 0644] | blob |
| hphp/test/slow/enum-class-order.php.expect | [new file with mode: 0644] | blob |