| commit | e04a1210e7687963fa12041337ef370e97a6e737 | |
| author | Bin Liu <binliu@fb.com> | |
| Wed, 19 Dec 2018 02:04:14 +0000 (18 18:04 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 19 Dec 2018 02:12:10 +0000 (18 18:12 -0800) | ||
| tree | b05b1abc67c13ded2a9ec07e4d46fceda5e340cf | treesnapshot (tar.gz zip) |
| parent | 7fe2092a5dd8964fb944e6b28242ec88ac63bf18 | commitdiff |
avoid jitting when dumping serialized profile data
Summary:
When retranslateAll is scheduled but not complete, no more profile/live translations are created.
However, we are setting s_retranslateAllComplete before serializing profile data, which makes it possible to have live translations being created while we write out profile data.
This can lead to race conditions when accessing the profile data.
Reviewed By: ottoni
Differential Revision: D13502787
fbshipit-source-id: 8b32022e187ba6e0ea2a744d51bd6b7b9d88aab7
Summary:
When retranslateAll is scheduled but not complete, no more profile/live translations are created.
However, we are setting s_retranslateAllComplete before serializing profile data, which makes it possible to have live translations being created while we write out profile data.
This can lead to race conditions when accessing the profile data.
Reviewed By: ottoni
Differential Revision: D13502787
fbshipit-source-id: 8b32022e187ba6e0ea2a744d51bd6b7b9d88aab7
| hphp/runtime/vm/jit/mcgen-translate.cpp | diffblobblamehistory |