| commit | de50803000c10c2caf0ed00baa07e6c8dbd9e646 | |
| author | Michael Colavita <mcolavita@fb.com> | |
| Sat, 24 Oct 2020 22:22:40 +0000 (24 15:22 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 24 Oct 2020 22:24:50 +0000 (24 15:24 -0700) | ||
| tree | 5101df66ea60d6f6e85f027e8499196c8815637f | treesnapshot (tar.gz zip) |
| parent | e56287927d57824161a60f4be43654e57401601b | commitdiff |
Make NativeImpl layout-agnostic
Summary: While we intend to supply bespoke translations of layout-sensitive builtin functions, we hope to only do so for FCallBuiltin. Therefore we only use optimized implementations of builtins functions when they are dispatched from FCallBuiltin. Inlined NativeImpls may no longer use optimized translations. We do not anticipate this having a performance impact, as in RepoAuth mode all non-dynamic builtin invocations should be replaced by FCallBuiltin.
Differential Revision: D24477685
fbshipit-source-id: 408026c9a418d174d6bf8ff0cb5438ee76e645e5
Summary: While we intend to supply bespoke translations of layout-sensitive builtin functions, we hope to only do so for FCallBuiltin. Therefore we only use optimized implementations of builtins functions when they are dispatched from FCallBuiltin. Inlined NativeImpls may no longer use optimized translations. We do not anticipate this having a performance impact, as in RepoAuth mode all non-dynamic builtin invocations should be replaced by FCallBuiltin.
Differential Revision: D24477685
fbshipit-source-id: 408026c9a418d174d6bf8ff0cb5438ee76e645e5
| hphp/runtime/vm/jit/irgen-bespoke.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/irgen-builtin.cpp | diffblobblamehistory |