Delete StructArray and Shape
commitdd67e34f7b408aac997f9a3f603d78e0bd684ca2
authorAlex Malyshev <alexanderm@fb.com>
Wed, 6 Jul 2016 01:44:47 +0000 (5 18:44 -0700)
committerHhvm Bot <hhvm-bot-bot@fb.com>
Sun, 10 Jul 2016 05:32:15 +0000 (9 22:32 -0700)
tree87ce47c797ed01c683b7bbb93e15474f03ddf82f
parentce0ffbd4c26fc076bc589cd0c72e9fc99e7a1f57
Delete StructArray and Shape

Summary:
We're not using them, and the sentiment I've heard from the team is
that if we want them we're going to have to rewrite them from scratch.

This still leaves behind the NewStructArray opcode.  The last time I tried to
delete that it was a performance regression, presumably because of how the
emitter packs the array element pairs more efficiently.

Reviewed By: paulbiss

Differential Revision: D3505834

fbshipit-source-id: c7dda943f93d2e2026d205b52490104240155f6c
51 files changed:
hphp/compiler/analysis/emitter.cpp
hphp/doc/ir.specification
hphp/runtime/base/apc-array.cpp
hphp/runtime/base/apc-stats.cpp
hphp/runtime/base/apc-typed-value.cpp
hphp/runtime/base/array-common.cpp
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/array-iterator.cpp
hphp/runtime/base/array-iterator.h
hphp/runtime/base/empty-array.cpp
hphp/runtime/base/header-kind.h
hphp/runtime/base/heap-collect.cpp
hphp/runtime/base/heap-report.cpp
hphp/runtime/base/heap-scan.h
hphp/runtime/base/memory-manager-defs.h
hphp/runtime/base/memory-manager.cpp
hphp/runtime/base/mixed-array-defs.h
hphp/runtime/base/mixed-array.cpp
hphp/runtime/base/mixed-array.h
hphp/runtime/base/runtime-option.h
hphp/runtime/base/shape.cpp [deleted file]
hphp/runtime/base/shape.h [deleted file]
hphp/runtime/base/struct-array-defs.h [deleted file]
hphp/runtime/base/struct-array.cpp [deleted file]
hphp/runtime/base/struct-array.h [deleted file]
hphp/runtime/ext/asio/ext_await-all-wait-handle.cpp
hphp/runtime/ext/asio/ext_await-all-wait-handle.h
hphp/runtime/ext/objprof/ext_heapgraph.cpp
hphp/runtime/ext/objprof/ext_objprof.cpp
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/jit/code-gen-x64.cpp
hphp/runtime/vm/jit/dce.cpp
hphp/runtime/vm/jit/extra-data.h
hphp/runtime/vm/jit/ir-builder.cpp
hphp/runtime/vm/jit/ir-instruction.cpp
hphp/runtime/vm/jit/irgen-minstr.cpp
hphp/runtime/vm/jit/irlower-internal-inl.h
hphp/runtime/vm/jit/memory-effects.cpp
hphp/runtime/vm/jit/simplify.cpp
hphp/runtime/vm/jit/target-profile.h
hphp/runtime/vm/jit/type-constraint-inl.h
hphp/runtime/vm/jit/type-constraint.cpp
hphp/runtime/vm/jit/type-constraint.h
hphp/runtime/vm/jit/type-inl.h
hphp/runtime/vm/jit/type-specialization-inl.h
hphp/runtime/vm/jit/type-specialization.cpp
hphp/runtime/vm/jit/type-specialization.h
hphp/runtime/vm/jit/type.cpp
hphp/runtime/vm/jit/type.h
hphp/runtime/vm/verifier/check-func.cpp