Deprecate disallow_assign_by_ref option, default to always
commitdcaafc33a7c883da479a1d844d0dcadb807ba554
authorMike Qian <mqian@fb.com>
Tue, 26 Feb 2019 21:13:28 +0000 (26 13:13 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 26 Feb 2019 21:17:15 +0000 (26 13:17 -0800)
tree2854ed950c8da06d67e537bcf0f7298ed58917d6
parentc7453f5724147f9d0b1e3f0d0ac324673d47571d
Deprecate disallow_assign_by_ref option, default to always

Summary:
We announced in 4.0.0 that this behavior would be removed in a future release.

This change also deprecates error 4154 and combines it into error 4299.

Reviewed By: billf, alexeyt

Differential Revision: D14217160

fbshipit-source-id: 3fa9397b72a711102e3aa0b683db91020da6cde8
17 files changed:
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/options/globalOptions.ml
hphp/hack/src/options/globalOptions.mli
hphp/hack/src/options/typecheckerOptions.ml
hphp/hack/src/server/serverConfig.ml
hphp/hack/src/typing/typing.ml
hphp/hack/test/errors/error_map.ml
hphp/hack/test/typecheck/reactive/HH_FLAGS [deleted file]
hphp/hack/test/typecheck/references/HH_FLAGS [deleted file]
hphp/hack/test/typecheck/references/call_time_reference3.php.exp
hphp/hack/test/typecheck/references/refs_in_array/HH_FLAGS [deleted file]
hphp/hack/test/typecheck/references/refs_in_array/element_assign1.php.exp
hphp/hack/test/typecheck/references/refs_in_array/element_assign1b.php.exp
hphp/hack/test/typecheck/references/strict_reference.php.exp