| commit | dca0fb17cd49f6fcd7eac7e7ee14f7b4dd1cd32d | |
| author | Guilherme Ottoni <ottoni@fb.com> | |
| Thu, 15 Aug 2019 05:05:49 +0000 (14 22:05 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 15 Aug 2019 05:09:50 +0000 (14 22:09 -0700) | ||
| tree | cb6b30f88c1e1d3e5a74913849fb7d47241723bf | treesnapshot (tar.gz zip) |
| parent | ba0ff5a2fd4bf32b4cb9c25bd21796a4a98f521c | commitdiff |
Fix broken xmlreader test
Summary:
This test has been broken in master for more than a day. I bisected the problem
to D16788707, which upgraded the libxml library. Debugging the test, I noticed
that the behavior of function xmlParserInputBufferCreateMem when passed an empty
string changed in the new library, which resulted in hhvm dropping a warning.
I'm dropping the empty string case from the test, instead of just dropping the
warning from the output, to avoid breaking the test for open-source users.
Reviewed By: ricklavoie
Differential Revision: D16824356
fbshipit-source-id: 9000e37940a7ba4cdd7ded725a12332c3553713d
Summary:
This test has been broken in master for more than a day. I bisected the problem
to D16788707, which upgraded the libxml library. Debugging the test, I noticed
that the behavior of function xmlParserInputBufferCreateMem when passed an empty
string changed in the new library, which resulted in hhvm dropping a warning.
I'm dropping the empty string case from the test, instead of just dropping the
warning from the output, to avoid breaking the test for open-source users.
Reviewed By: ricklavoie
Differential Revision: D16824356
fbshipit-source-id: 9000e37940a7ba4cdd7ded725a12332c3553713d
| hphp/test/zend/good/ext/xmlreader/tests/001.php | diffblobblamehistory | |
| hphp/test/zend/good/ext/xmlreader/tests/001.php.expectf | diffblobblamehistory |