Clean up, part 11: gut array provenance
commitdc3e7b5f8cba0a0e8e3b53b6d28c9712fb515685
authorShaunak Kishore <kshaunak@fb.com>
Fri, 2 Apr 2021 04:00:07 +0000 (1 21:00 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 2 Apr 2021 04:01:14 +0000 (1 21:01 -0700)
treea38dd18d6921b19f992b30eece238f04bf4dfa0d
parente23de7c5d125ed81d55b18d6385ff8373199728c
Clean up, part 11: gut array provenance

Summary:
This diff doesn't COMPLETELY eliminate arrprov, but it gets close.

We get rid of:

arrayWantsTag
getTag
setTag
reassignTag
all static array tag stuff
all DArray and VArray constructors

In a follow-up, we'll clean up the several dozen TagOverride / RUNTIME_LOCATION callsites and delete arrprov::Tag.

Reviewed By: ricklavoie

Differential Revision: D27521563

fbshipit-source-id: 295918d2b1d2cbf11b5b124be3dc9507ac9ce8e9
34 files changed:
hphp/runtime/base/apc-array.cpp
hphp/runtime/base/array-common.cpp
hphp/runtime/base/array-data-inl.h
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/array-init.cpp
hphp/runtime/base/array-init.h
hphp/runtime/base/array-provenance.cpp
hphp/runtime/base/array-provenance.h
hphp/runtime/base/array-util.cpp
hphp/runtime/base/bespoke/monotype-dict.cpp
hphp/runtime/base/bespoke/struct-dict.cpp
hphp/runtime/base/enum-cache.cpp
hphp/runtime/base/enum-cache.h
hphp/runtime/base/ini-setting.cpp
hphp/runtime/base/mixed-array.cpp
hphp/runtime/base/mixed-array.h
hphp/runtime/base/object-data.cpp
hphp/runtime/base/packed-array.cpp
hphp/runtime/base/packed-array.h
hphp/runtime/base/type-variant.h
hphp/runtime/base/variable-serializer.cpp
hphp/runtime/base/variable-unserializer.cpp
hphp/runtime/debugger/dummy_sandbox.cpp
hphp/runtime/ext/array/ext_array.cpp
hphp/runtime/ext/asio/ext_external-thread-event-wait-handle.cpp
hphp/runtime/ext/enum/ext_enum.cpp
hphp/runtime/ext/json/JSON_parser.cpp
hphp/runtime/ext/json/jsonc_parser.cpp
hphp/runtime/ext/pdo/ext_pdo.cpp
hphp/runtime/ext/vsdebug/session.cpp
hphp/runtime/vm/event-hook.cpp
hphp/runtime/vm/hhbc.cpp
hphp/runtime/vm/jit/irgen-builtin.cpp