Improve failure mode checking of <<__Atom>> HH\Elt<_, _>nightly-2020.10.30
commitdc31772e1b47d8c4879a4c36610d22df08fc9374
authorShayne Fletcher <shaynefletcher@fb.com>
Fri, 30 Oct 2020 00:38:34 +0000 (29 17:38 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 30 Oct 2020 00:40:27 +0000 (29 17:40 -0700)
tree16e3a4c3327b5b23d4a0e8a03c039c671c6d7e65
parent83ee2e586a4f2dea472b4ead450544f05bb0e777
Improve failure mode checking of <<__Atom>> HH\Elt<_, _>

Summary: Check type constants and generic type parameters in enum type positions of `HH\Elt<_, _>`s resolve to class types and provide meaningful error messages in the event they don't.

Reviewed By: paulbiss

Differential Revision: D24626748

fbshipit-source-id: d3bb5a2e65a7c19e1c7bacf2fc8c0abca5fc79f2
13 files changed:
hphp/hack/src/hhbc/emit_body.rs
hphp/test/slow/enum_class/enum_class16.php [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class16.php.expectf [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class16.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class16.php.opts [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class17.php [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class17.php.expectf [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class17.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class17.php.opts [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class18.php [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class18.php.expectf [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class18.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/enum_class/enum_class18.php.opts [new file with mode: 0644]