| commit | daef913ba35db6d30817cdef9f909ea4d9e5d07f | |
| author | Daniel Neiter <dneiter@fb.com> | |
| Tue, 10 Sep 2019 18:43:50 +0000 (10 11:43 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 10 Sep 2019 18:46:10 +0000 (10 11:46 -0700) | ||
| tree | 47f317c12c2f1b855e6e5733fcf3db80a22795ec | treesnapshot (tar.gz zip) |
| parent | 5c7248d63f8052ef9bdd7309f9baa3589962bc70 | commitdiff |
prepare ext_memcache and ext_memcached for references deprecation
Summary:
### ext_memcache
Remove optional &$flags parameter from Memcache::get and memcache_get. This parameter was never populated in C++ anyway.
### ext_memcached
Introduce the following inout functions:
```
Memcached::getWithCasToken()
Memcached::getByKeyWithCasToken()
Memcached::getMultiWithCasTokens()
Memcached::getMultiByKeyWithCasTokens()
```
I plan to wait for 1 HHVM release and then remove optional &$cas_token and &$cas_tokens parameters from corresponding reffy functions.
The reason for splitting these functions off: extension implementation sends different option to memcached server depending on whether $cas_token was passed in or not.
Reviewed By: billf
Differential Revision: D17139942
fbshipit-source-id: b149050ce54a0e4dfaf4e62edff1d54333b581b5
Summary:
### ext_memcache
Remove optional &$flags parameter from Memcache::get and memcache_get. This parameter was never populated in C++ anyway.
### ext_memcached
Introduce the following inout functions:
```
Memcached::getWithCasToken()
Memcached::getByKeyWithCasToken()
Memcached::getMultiWithCasTokens()
Memcached::getMultiByKeyWithCasTokens()
```
I plan to wait for 1 HHVM release and then remove optional &$cas_token and &$cas_tokens parameters from corresponding reffy functions.
The reason for splitting these functions off: extension implementation sends different option to memcached server depending on whether $cas_token was passed in or not.
Reviewed By: billf
Differential Revision: D17139942
fbshipit-source-id: b149050ce54a0e4dfaf4e62edff1d54333b581b5