Migrate tests from `rx` to `oldrx` to keep good coverage
commitdae146418ca7b306c9c88ca90a0df60b24ef577d
authorLeo Osvald <leoo@fb.com>
Mon, 3 May 2021 19:20:32 +0000 (3 12:20 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 3 May 2021 19:21:42 +0000 (3 12:21 -0700)
tree8b8ce2e588b390d1fc882330bebfc6ae0bb29263
parente846d8b0b78aecf9a3490db5ef67a99931528609
Migrate tests from `rx` to `oldrx` to keep good coverage

Summary:
`rx` contexts are deprecated (may be superseded by local/shallow purity),
so preserve coverage of safe/unsafe capabilities
by moving away to the test-only old versions (`oldrx*`).

Also, fix `oldrx_shallow` to unsafely provide call-only `RxLocal` capability.

Reviewed By: rodmk

Differential Revision: D28110479

fbshipit-source-id: 91a3f095e58e4a08c3c058c89dcae0fbb06bf3ef
13 files changed:
hphp/hack/test/hhi/coeffects.hhi
hphp/hack/test/typecheck/coeffects/closures_definition.php
hphp/hack/test/typecheck/coeffects/closures_restore_env.php
hphp/hack/test/typecheck/coeffects/closures_subtyping_explicit.bad.php
hphp/hack/test/typecheck/coeffects/closures_subtyping_explicit.bad.php.exp
hphp/hack/test/typecheck/coeffects/closures_subtyping_explicit.good.php
hphp/hack/test/typecheck/coeffects/closures_subtyping_implicit.bad.php
hphp/hack/test/typecheck/coeffects/closures_subtyping_implicit.bad.php.exp
hphp/hack/test/typecheck/coeffects/closures_subtyping_implicit.good.php
hphp/hack/test/typecheck/coeffects/ctx-const-bounds_call-into-more-pure.php
hphp/hack/test/typecheck/coeffects/ctx-const-bounds_multiple-conflicting.php
hphp/hack/test/typecheck/coeffects/ctx-const-bounds_multiple-conflicting.php.exp
hphp/hack/test/typecheck/context_constant_override.php