| commit | da7a1b61df154fdb21f883f575e1ccae4fadcb46 | |
| author | Drew Paroski <andrewparoski@fb.com> | |
| Tue, 3 Jun 2014 08:13:59 +0000 (3 01:13 -0700) | ||
| committer | JoelMarcey <joelm@fb.com> | |
| Tue, 3 Jun 2014 23:58:57 +0000 (3 16:58 -0700) | ||
| tree | 56411fef04b054ba47b56e3ca984612df4710044 | treesnapshot (tar.gz zip) |
| parent | ca47baca450dece0597e63330ad27617bf1feeb6 | commitdiff |
Fix refcounting bug in Pair::at()
Summary: Pair::at() was not incReffing the value it returned, causing HHVM to free
the value early causing crashes or other bad behavior. This diff fixes the
refcounting bug.
Reviewed By: @elgenie
Differential Revision: D1361339
Summary: Pair::at() was not incReffing the value it returned, causing HHVM to free
the value early causing crashes or other bad behavior. This diff fixes the
refcounting bug.
Reviewed By: @elgenie
Differential Revision: D1361339
| hphp/runtime/ext/ext_collections.cpp | diffblobblamehistory | |
| hphp/test/slow/collection_classes/823.php | diffblobblamehistory | |
| hphp/test/slow/collection_classes/823.php.expect | diffblobblamehistory |