| commit | d98f70b56fb7cd28052cefe93738a17e3ff1d6db | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Mon, 12 Oct 2020 07:36:31 +0000 (12 00:36 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 12 Oct 2020 07:39:52 +0000 (12 00:39 -0700) | ||
| tree | de8283e14968f402ab07644ec7301eae3282685f | treesnapshot (tar.gz zip) |
| parent | 0b651289c45ec8747667ff71c6f201421b20ecf3 | commitdiff |
Fix spurious failures in tier overrides tests
Summary:
These tests set a RSS limit. However we can easily go over
this limit during init (for example if we need to unpack embedded
data). If we do so, the runtime fails in inscrutable ways (with
std::bad_alloc and other random crashes). This is especially hard to
diagnose because if the hackc binary already exists, or if you run the
tests as a group (and some other test unpacks the embedded data),
everything works. It only fails if you don't have the unpacked data
and you run the test by itself.
Since this is just testing the override mechanism, we don't actually
care about the RSS, so just remove that config. Remove previous
attempt to bandaid this issue by ignoring "failed to init member
reflection" errors (which is a serious issue and shouldn't be ignored
with a regexp).
Reviewed By: jano
Differential Revision: D24245818
fbshipit-source-id: 644f105cfb1c32defdfaa618f5dd567a2f8fe609
Summary:
These tests set a RSS limit. However we can easily go over
this limit during init (for example if we need to unpack embedded
data). If we do so, the runtime fails in inscrutable ways (with
std::bad_alloc and other random crashes). This is especially hard to
diagnose because if the hackc binary already exists, or if you run the
tests as a group (and some other test unpacks the embedded data),
everything works. It only fails if you don't have the unpacked data
and you run the test by itself.
Since this is just testing the override mechanism, we don't actually
care about the RSS, so just remove that config. Remove previous
attempt to bandaid this issue by ignoring "failed to init member
reflection" errors (which is a serious issue and shouldn't be ignored
with a regexp).
Reviewed By: jano
Differential Revision: D24245818
fbshipit-source-id: 644f105cfb1c32defdfaa618f5dd567a2f8fe609