move verify_select out of main match
commitd98ad3af6eb33ba32cc2123dbb5fb75c29bbaadf
authorAaron Orenstein <aorenste@fb.com>
Thu, 7 Jul 2022 16:39:45 +0000 (7 09:39 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 7 Jul 2022 16:39:45 +0000 (7 09:39 -0700)
treebcc0a8225b7d4171dfd9ae57d6c12a3ac62bfbfd
parent50ffa27cc9750de33b691b1b43ec81bda4d6520e
move verify_select out of main match

Summary:
Code cleanup: The verify step for Special::Select has gotten long so move it to its own function.

In addition the code for checking the prior Instr was unnecessarily complex - it really just needs to know that the prior Instr actually expected a Select - we already check the count when we check the prior Instr itself.

Differential Revision: D37594336

fbshipit-source-id: 96f46d69c72b454c9d4661570a172819be615a06
hphp/hack/src/hackc/ir/verify/verify.rs