Canonicalize (HH\)Rx\IS_ENABLED to simplify further changes
commitd8e72e20af754bd9d7cb693070be7adec54980e9
authorLeo Osvald <leoo@fb.com>
Mon, 28 Dec 2020 19:37:59 +0000 (28 11:37 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 28 Dec 2020 19:39:38 +0000 (28 11:39 -0800)
tree5eb7a79175dca98124363cd6ebb92181c40925a5
parent0f1750a8afca2a4ee2f4b4d3f5e7058bb645ebcc
Canonicalize (HH\)Rx\IS_ENABLED to simplify further changes

Summary:
`Rx\IS_ENABLED` is elaborated into `\HH\Rx\IS_ENABLED`, therefore
there is no need to handle the former as a special name during typechecking.

Also, clean up tests to use the more prevalent version: `Rx\IS_ENABLED`.

Reviewed By: DavidSnider

Differential Revision: D25711628

fbshipit-source-id: 0282edf86fd76f64b632c76d4b983f4c5c27b7bd
26 files changed:
hphp/hack/src/naming/naming_special_names.ml
hphp/hack/src/typing/nast_check/nast_reactivity_check.ml
hphp/hack/src/typing/nast_visitor.ml
hphp/hack/src/typing/tast_check/basic_reactivity_check.ml
hphp/hack/src/typing/typing.ml
hphp/hack/test/typecheck/reactive/cond_rx1.php
hphp/hack/test/typecheck/reactive/cond_typeconstant2.php
hphp/hack/test/typecheck/reactive/rx_if_enabled1.php
hphp/hack/test/typecheck/reactive/rx_if_enabled2.php
hphp/hack/test/typecheck/reactive/rx_if_enabled2.php.coeffects.exp
hphp/hack/test/typecheck/reactive/rx_if_enabled2.php.exp
hphp/hack/test/typecheck/reactive/rx_if_enabled3.php
hphp/hack/test/typecheck/reactive/rx_if_enabled3.php.coeffects.exp
hphp/hack/test/typecheck/reactive/rx_if_enabled3.php.exp
hphp/hack/test/typecheck/reactive/rx_if_enabled4.php
hphp/hack/test/typecheck/reactive/rx_if_enabled4.php.coeffects.exp
hphp/hack/test/typecheck/reactive/rx_if_enabled4.php.exp
hphp/hack/test/typecheck/reactive/static_props_rx_if_enabled1.php
hphp/hack/test/typecheck/reactive/test_rx_enabled1.php
hphp/hack/test/typecheck/reactive/test_rx_enabled1.php.exp
hphp/hack/test/typecheck/reactive/test_rx_enabled2.php
hphp/hack/test/typecheck/reactive/test_rx_enabled2.php.exp
hphp/hack/test/typecheck/reactive/test_rx_enabled4.php
hphp/hack/test/typecheck/reactive/test_rx_enabled6.php
hphp/hack/test/typecheck/reactive/test_rx_enabled6.php.exp
hphp/hack/test/typecheck/reactive/test_rx_enabled6.php.like_types.exp