convert ext_fb, ext_exif and ext_gd to use inout parameters instead of references
commitd8e4bf79cd7aa218742b4fcbf036ac63779f68e9
authorDaniel Neiter <dneiter@fb.com>
Fri, 20 Sep 2019 19:55:38 +0000 (20 12:55 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 20 Sep 2019 20:16:35 +0000 (20 13:16 -0700)
tree7cc13363092632032fb2942877da195aa7a25d00
parent948c9a17ab4125800cfb902abc6861690f11b4f8
convert ext_fb, ext_exif and ext_gd to use inout parameters instead of references

Summary:
1. Convert reference parameters to inout parameters.
2. Make optional reffy parameters required
3. annontate inout parameters __OutOnly wherever appropriate
4. Remove fb_stubout_intercept_handler and fb_rpc_intercept_handler from hhi - corresponding HHBM builtins no longer exist.

Reviewed By: paulbiss

Differential Revision: D17176392

fbshipit-source-id: 3b4ad9509d6526b83625439a3025c4d381003f83
57 files changed:
hphp/hack/hhi/stdlib/builtins_image.hhi
hphp/hack/test/typecheck/like_types/incorrect_type.php.exp
hphp/runtime/ext/apc/ext_apc.cpp
hphp/runtime/ext/apc/snapshot.cpp
hphp/runtime/ext/fb/ext_fb.cpp
hphp/runtime/ext/fb/ext_fb.h
hphp/runtime/ext/fb/ext_fb.php
hphp/runtime/ext/gd/ext_exif.php
hphp/runtime/ext/gd/ext_gd.cpp
hphp/runtime/ext/gd/ext_gd.h
hphp/runtime/ext/gd/ext_gd.php
hphp/test/slow/class-ptr/class-serde.php
hphp/test/slow/dict/fb_serialize.php
hphp/test/slow/ext_fb/compact_serialize.inc
hphp/test/slow/ext_fb/migratory_serialize.php
hphp/test/slow/ext_fb/serialize.php
hphp/test/slow/ext_fb/utf8ize.php
hphp/test/slow/ext_fb/utf8ize_noreplace.php
hphp/test/slow/ext_gd/getimagesize.php
hphp/test/slow/ext_gd/imagescale.php
hphp/test/slow/ext_image/1793.php
hphp/test/slow/ext_image/1793.php.expectregex
hphp/test/slow/ext_image/ico.php
hphp/test/slow/ext_string/htmlspecialchars.php
hphp/test/slow/ext_string/utf8ize_replace.php
hphp/test/slow/func-ptr/func-serde.php
hphp/test/slow/global_func/class_meth/dv_arr/serde.php
hphp/test/slow/global_func/class_meth/dv_arr_hack_arr/serde.php
hphp/test/slow/hack_arr_compat/fb_unserialize.php
hphp/test/slow/hack_arr_compat/varr_to_darr.php
hphp/test/slow/vec/fb_serialize.php
hphp/test/zend/good/ext/exif/tests/bug72819.php
hphp/test/zend/good/ext/exif/tests/exif002.php
hphp/test/zend/good/ext/gd/tests/imagefilledpolygon_negative.php.expectf
hphp/test/zend/good/ext/gd/tests/imagepolygon_negative.php.expectf
hphp/test/zend/good/ext/standard/tests/image/bug13213.php
hphp/test/zend/good/ext/standard/tests/image/bug72278.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_246x247.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_384x385.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_basic.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_error1.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_error1.php.expectf
hphp/test/zend/good/ext/standard/tests/image/getimagesize_jpgapp.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_swc.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_tif_mm.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation2.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation3.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation3.php.expectf
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation4.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation_003.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation_003.php.expectf
hphp/test/zend/good/ext/standard/tests/image/getimagesize_variation_005.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_wbmp.php
hphp/test/zend/good/ext/standard/tests/image/getimagesize_xbm.php
hphp/test/zend/good/ext/standard/tests/image/getimagesizefromstring1.php
hphp/test/zend/good/ext/standard/tests/image/image_type_to_mime_type.php