Make ReadOnly::Mutable the default
commitd8e30069703650ae98dd24feb168bb32cc70c41c
authorKaty Voor <voork@fb.com>
Mon, 8 Mar 2021 22:05:46 +0000 (8 14:05 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 8 Mar 2021 22:10:32 +0000 (8 14:10 -0800)
treeddc7b98434c29a7c20fdbc6aee99122a020518d0
parent0953488b11b67c612ec0bd86974ea45f97f9261c
Make ReadOnly::Mutable the default

Summary:
ReadOnly::Mutable should be the default because it is valid for
```
[mutable] $a  = [mutable] $b
```
but not for
```
[any] $a = [any] $b
```

```rustfmt```

Reviewed By: alexeyt

Differential Revision: D26832312

fbshipit-source-id: a7ab117ccaa50d839d5757e3ad09e8806c4648ff
22 files changed:
hphp/hack/src/hhbc/emit_body.rs
hphp/hack/src/hhbc/emit_class.rs
hphp/hack/src/hhbc/emit_expression.rs
hphp/hack/src/hhbc/emit_property.rs
hphp/hack/src/hhbc/emit_statement.rs
hphp/hack/test/enum_atom/compilation/test.php.exp
hphp/runtime/vm/hhbc.cpp
hphp/runtime/vm/member-key.cpp
hphp/runtime/vm/member-key.h
hphp/test/quick/access_modifier.hhas
hphp/test/quick/asm_array.hhas
hphp/test/quick/asm_assert_optobj.hhas
hphp/test/quick/asm_class.hhas
hphp/test/quick/asm_prop_init.hhas
hphp/test/quick/baseH.hhas
hphp/test/quick/check_init_prop.hhas
hphp/test/quick/constructor_destructor.hhas
hphp/test/quick/member_key_offset.hhas
hphp/test/quick/member_key_offset.hhas.expectf
hphp/test/quick/member_mode_inconsistency.hhas
hphp/test/quick/member_mode_inconsistency2.hhas
hphp/test/quick/neg_iva.hhas