| commit | d8d07e7daa4f73f4a20b809121bde68f3b12e67a | |
| author | Ted Spence <tspence@fb.com> | |
| Fri, 13 Sep 2019 00:15:19 +0000 (12 17:15 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 13 Sep 2019 00:28:50 +0000 (12 17:28 -0700) | ||
| tree | d14a4ceb7a942061292df341bfa378577ec7265c | treesnapshot (tar.gz zip) |
| parent | 7112f8f4762993e62feb4445f09ba3ab455751dd | commitdiff |
Switch tests to run on LocalIndex
Summary:
Fix remaining issues preventing tests from being moved to LocalIndex mode.
* Autocomplete results are being sorted in the wrong order! I was using dedup_and_sort backwards. That had caused "Foo2" to appear before "Foo" in the results. Fixed by switching the order of parameters to dedup_and_sort. This required updating a decent number of assertions.
* Namespace searching no longer returns full namespace plus names in the results. We now only autocomplete the untyped portion of your string. For example, in the past, we used to autocomplete "HH\Lib\Str\jAUTO332" with "HH\Lib\Str\join"; but now we only report "join". This involved updating a few more assertions.
* Files that are being currently edited need to be updated by the local search index.
Reviewed By: 2BitSalute
Differential Revision: D17286559
fbshipit-source-id: 4872127989f98fd4e0dd2a3a9da83a9b68e5a58b
Summary:
Fix remaining issues preventing tests from being moved to LocalIndex mode.
* Autocomplete results are being sorted in the wrong order! I was using dedup_and_sort backwards. That had caused "Foo2" to appear before "Foo" in the results. Fixed by switching the order of parameters to dedup_and_sort. This required updating a decent number of assertions.
* Namespace searching no longer returns full namespace plus names in the results. We now only autocomplete the untyped portion of your string. For example, in the past, we used to autocomplete "HH\Lib\Str\jAUTO332" with "HH\Lib\Str\join"; but now we only report "join". This involved updating a few more assertions.
* Files that are being currently edited need to be updated by the local search index.
Reviewed By: 2BitSalute
Differential Revision: D17286559
fbshipit-source-id: 4872127989f98fd4e0dd2a3a9da83a9b68e5a58b