| commit | d7a3be1d72bcc5ed06e6797e99294c8e4ed901d0 | |
| author | Brett Simmers <bsimmers@fb.com> | |
| Tue, 24 Jun 2014 22:44:55 +0000 (24 15:44 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Fri, 27 Jun 2014 08:09:33 +0000 (27 01:09 -0700) | ||
| tree | e321508f220748f3a76519ea2438e1cbaba5c7cd | treesnapshot (tar.gz zip) |
| parent | 13a9891308ad2195e67e45950a32afdc7ac06f13 | commitdiff |
Fix some Type::Null stuff, LbGbl guard relaxation
Summary: - We were being sloppy with Type::Null in isKnownDataType and toDataType,
mostly for historical reasons. I cleaned that up and nothing seemed to break.
- IsType<Null> was just checking for KindOfNull. I fixed it to check for <=
KindOfNull to also get KindOfUninit.
- LdGbl is roughly the same as LdLoc but we weren't tracing through it in guard
relaxation.
The new test is fixed by having either the second or the third item, since it
was a combination of both causing issues.
Reviewed By: @ottoni
Differential Revision: D1401528
Summary: - We were being sloppy with Type::Null in isKnownDataType and toDataType,
mostly for historical reasons. I cleaned that up and nothing seemed to break.
- IsType<Null> was just checking for KindOfNull. I fixed it to check for <=
KindOfNull to also get KindOfUninit.
- LdGbl is roughly the same as LdLoc but we weren't tracing through it in guard
relaxation.
The new test is fixed by having either the second or the third item, since it
was a combination of both causing issues.
Reviewed By: @ottoni
Differential Revision: D1401528
18 files changed: