| commit | d78008d6ab441dac65c6015f67b2e45ebd70a077 | |
| author | Tim Starling <tstarling@wikimedia.org> | |
| Mon, 11 May 2015 21:12:47 +0000 (11 14:12 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Mon, 11 May 2015 21:30:35 +0000 (11 14:30 -0700) | ||
| tree | 36c045d690afbce00cd146877a8ac927ebcb56f3 | treesnapshot (tar.gz zip) |
| parent | a70e46bba40ae1f64dbebee26ebd86c820fd0d67 | commitdiff |
Fix DynamicContentCache and static content under FastCGI
Summary: When sending static content via sendStaticContent(), for example on a
DynamicContentCache hit, Transport::onSendEnd() was not called, and so
the webserver would hang forever waiting for an FCGI_END_REQUEST record.
Also, the key used for DynamicContentCache was different when storing
and retrieving, so it always missed. It used reqURI.path() when
retrieving, and reqURI.absolutePath() when storing, which may have
possibly been the same under certain test circumstances but is not the
same under FastCGI.
Closes https://github.com/facebook/hhvm/pull/5310
Reviewed By: @sgolemon
Differential Revision: D2056781
Summary: When sending static content via sendStaticContent(), for example on a
DynamicContentCache hit, Transport::onSendEnd() was not called, and so
the webserver would hang forever waiting for an FCGI_END_REQUEST record.
Also, the key used for DynamicContentCache was different when storing
and retrieving, so it always missed. It used reqURI.path() when
retrieving, and reqURI.absolutePath() when storing, which may have
possibly been the same under certain test circumstances but is not the
same under FastCGI.
Closes https://github.com/facebook/hhvm/pull/5310
Reviewed By: @sgolemon
Differential Revision: D2056781
| hphp/runtime/server/http-request-handler.cpp | diffblobblamehistory |