| commit | d5dd7f86f29be5d2fbdf4bd040b7460bc3c2c3d4 | |
| author | Millie Chen <milliechen@fb.com> | |
| Thu, 23 Sep 2021 01:25:30 +0000 (22 18:25 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 23 Sep 2021 01:28:00 +0000 (22 18:28 -0700) | ||
| tree | ece3916a63641207c13b8a4385b213cd4c1149ad | treesnapshot (tar.gz zip) |
| parent | c4ec9a76588311b23fd755fb266d3b2e99a69288 | commitdiff |
Further cleanup in compile_ffi.rs
Summary:
- Eliminate unnecessary casts in `hackc_compile_from_text_cpp_ffi` by passing in pointer types directly
- Add `ExternalDeclProvider::new` to avoid exposing `PhantomData` to the client
Reviewed By: shayne-fletcher
Differential Revision: D31093843
fbshipit-source-id: bb7a8bbab5ff1235fdbf847750bf36bbdfd53a1f
Summary:
- Eliminate unnecessary casts in `hackc_compile_from_text_cpp_ffi` by passing in pointer types directly
- Add `ExternalDeclProvider::new` to avoid exposing `PhantomData` to the client
Reviewed By: shayne-fletcher
Differential Revision: D31093843
fbshipit-source-id: bb7a8bbab5ff1235fdbf847750bf36bbdfd53a1f
| hphp/hack/src/hhbc/compile_ffi.rs | diffblobblamehistory | |
| hphp/hack/src/hhbc/external_decl_provider/lib.rs | diffblobblamehistory |