Add is_declaration to SymbolOccurrence
commitd5c1427d71b7542c6642b34c0066f556a2aab187
authorJake Bailey <jakebailey@fb.com>
Sat, 7 Apr 2018 00:21:43 +0000 (6 17:21 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Sat, 7 Apr 2018 00:23:57 +0000 (6 17:23 -0700)
tree54aead74dab454a356d6538bf9c0fcc8db876076
parent024b7c4d101ba11cca5d9507638b91815e4e2bf7
Add is_declaration to SymbolOccurrence

Summary: In order to consume the output of IdentifySymbolService in FindRefsService, FindRefs needs to distinguish between declarations and references. This adds a new property to SymbolOccurrence to allow it to do so.

Reviewed By: pittsw

Differential Revision: D6903650

fbshipit-source-id: 11102b95c270be33cd3721ab8859216111302c01
45 files changed:
hphp/hack/src/client/clientGetDefinition.ml
hphp/hack/src/server/identifySymbolService.ml
hphp/hack/src/utils/symbolOccurrence.ml
hphp/hack/test/identify_symbol/abstract_const.php.exp
hphp/hack/test/identify_symbol/catch.php.exp
hphp/hack/test/identify_symbol/class.php.exp
hphp/hack/test/identify_symbol/classname.php.exp
hphp/hack/test/identify_symbol/const.php.exp
hphp/hack/test/identify_symbol/constructor_inheritance.php.exp
hphp/hack/test/identify_symbol/decl_const.php.exp
hphp/hack/test/identify_symbol/decl_function.flags [new file with mode: 0644]
hphp/hack/test/identify_symbol/decl_function.php [new file with mode: 0644]
hphp/hack/test/identify_symbol/decl_function.php.exp [copied from hphp/hack/test/identify_symbol/function.php.exp with 63% similarity]
hphp/hack/test/identify_symbol/decl_method.php.exp
hphp/hack/test/identify_symbol/decl_property.php.exp
hphp/hack/test/identify_symbol/decl_typeconst.php.exp
hphp/hack/test/identify_symbol/decl_typedef.flags
hphp/hack/test/identify_symbol/decl_typedef.php
hphp/hack/test/identify_symbol/decl_typedef.php.exp
hphp/hack/test/identify_symbol/enum_member.php.exp
hphp/hack/test/identify_symbol/fake_member.php.exp
hphp/hack/test/identify_symbol/function.php.exp
hphp/hack/test/identify_symbol/function_parameter.php.exp
hphp/hack/test/identify_symbol/global_const.php.exp
hphp/hack/test/identify_symbol/global_const_assign.php.exp
hphp/hack/test/identify_symbol/idx.php.exp
hphp/hack/test/identify_symbol/instanceof.php.exp
hphp/hack/test/identify_symbol/intersection.php.exp
hphp/hack/test/identify_symbol/local_var.php.exp
hphp/hack/test/identify_symbol/method.php.exp
hphp/hack/test/identify_symbol/method_inheritance.php.exp
hphp/hack/test/identify_symbol/new.php.exp
hphp/hack/test/identify_symbol/new_constructor.php.exp
hphp/hack/test/identify_symbol/property.php.exp
hphp/hack/test/identify_symbol/special_function.php.exp
hphp/hack/test/identify_symbol/static_method.php.exp
hphp/hack/test/identify_symbol/static_property.php.exp
hphp/hack/test/identify_symbol/static_property2.php.exp
hphp/hack/test/identify_symbol/typeconst.php.exp
hphp/hack/test/identify_symbol/typeconst_access.php.exp
hphp/hack/test/identify_symbol/typedef.php.exp
hphp/hack/test/identify_symbol/typedef2.php.exp
hphp/hack/test/identify_symbol/undefined_symbol.php.exp
hphp/hack/test/identify_symbol/xhp_attr_use.php.exp
hphp/hack/test/identify_symbol/xhp_property.php.exp