| commit | d528527a051c7da6d0e7bd5b4d400ec3cd2839ea | |
| author | Gabe Levi <gabe@fb.com> | |
| Thu, 12 Apr 2018 21:03:52 +0000 (12 14:03 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 12 Apr 2018 21:08:51 +0000 (12 14:08 -0700) | ||
| tree | 64c182ced00bed83d442c091b1d6350ecc53bdbd | treesnapshot (tar.gz zip) |
| parent | 99e4c5471735d57f614e507733096cfa8ba88300 | commitdiff |
Work around non-blocking fd issue on Windows.
Summary:
I reported the Lwt issue here:
https://github.com/ocsigen/lwt/issues/574. The long story short is that
reading from non-blocking fds on Windows doesn't seem to yield to other
threads, even when the fd isn't ready to read. I'm not sure the cause.
While we could just revert back to using blocking fds, we'd need to
either workaround https://github.com/ocsigen/lwt/issues/569 or ask for
a lwt release and update lwt.
Reviewed By: ljw1004
Differential Revision: D7603653
fbshipit-source-id: d6f9b4ed256cfa5b1fb286f9bd41c75748c28ddc
Summary:
I reported the Lwt issue here:
https://github.com/ocsigen/lwt/issues/574. The long story short is that
reading from non-blocking fds on Windows doesn't seem to yield to other
threads, even when the fd isn't ready to read. I'm not sure the cause.
While we could just revert back to using blocking fds, we'd need to
either workaround https://github.com/ocsigen/lwt/issues/569 or ask for
a lwt release and update lwt.
Reviewed By: ljw1004
Differential Revision: D7603653
fbshipit-source-id: d6f9b4ed256cfa5b1fb286f9bd41c75748c28ddc
| hphp/hack/src/utils/marshal_tools_lwt.ml | diffblobblamehistory |