| commit | d5111d02b4928352372cfe480d80a7f83558780f | |
| author | Matt Schellhas <rms@fb.com> | |
| Thu, 2 Jan 2020 19:26:46 +0000 (2 11:26 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 2 Jan 2020 19:28:40 +0000 (2 11:28 -0800) | ||
| tree | 0a30f2933a299a3d2397921f4fd65c2dfa930673 | treesnapshot (tar.gz zip) |
| parent | 1dc5ba0313423c6636fc66ddf6e75edf590e0a9c | commitdiff |
Additional tests to verify Hack visibility expansion in type hierarchies
Summary:
There was an issue where it looked like we weren't handling expanding visibility up a type hierarchy (allowing a public function to override a protected one for example).
It turns out that hack does support that, except for convoluted edge cases. These tests help confirm that.
Reviewed By: vassilmladenov
Differential Revision: D19264834
fbshipit-source-id: 6a6f922a6e91ab99eabc5d7bd98c4c954314369c
Summary:
There was an issue where it looked like we weren't handling expanding visibility up a type hierarchy (allowing a public function to override a protected one for example).
It turns out that hack does support that, except for convoluted edge cases. These tests help confirm that.
Reviewed By: vassilmladenov
Differential Revision: D19264834
fbshipit-source-id: 6a6f922a6e91ab99eabc5d7bd98c4c954314369c
| hphp/hack/test/typecheck/visibilities/T59074374.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/visibilities/T59074374.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/visibilities/function_expansion.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/visibilities/function_expansion.php.exp | [new file with mode: 0644] | blob |